Skip to content

fix(eth): Set the ETH properties at the correct time #11182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2025
Merged

fix(eth): Set the ETH properties at the correct time #11182

merged 2 commits into from
Mar 27, 2025
+82 −4

Conversation

me-no-dev
Copy link
Member

This pull request includes several changes to the ETHClass in the libraries/Ethernet/src/ETH.cpp and libraries/Ethernet/src/ETH.h files. The changes primarily focus on adding support for configuring Ethernet settings such as full duplex mode, link speed, and auto-negotiation, as well as ensuring these settings are properly managed during the Ethernet initialization and shutdown processes.

Enhancements to Ethernet Configuration:

  • Added new member variables _eth_started, _link_speed, _full_duplex, and _auto_negotiation to the ETHClass to store Ethernet configuration settings.
  • Implemented new methods setFullDuplex, setLinkSpeed, and setAutoNegotiation to allow configuration of Ethernet settings before calling ETH.begin(). Each method includes validation to ensure settings are applied correctly. [1] [2] [3]
  • Added private methods _setFullDuplex, _setLinkSpeed, and _setAutoNegotiation to apply the settings to the Ethernet hardware.

Initialization and Shutdown Process:

  • Modified the ETHClass::begin and ETHClass::beginSPI methods to apply the Ethernet configuration settings (full duplex, link speed, and auto-negotiation) during the initialization process if auto-negotiation is disabled. [1] [2]
  • Updated the ETHClass::end method to reset the _eth_started flag when shutting down the Ethernet interface.

Code Refactoring:

  • Refactored the ETHClass constructor to initialize the new member variables.
  • Ensured that the _eth_started flag is set to true after successful initialization and set to false during shutdown. [1] [2] [3]

Reference: #10923

@me-no-dev me-no-dev added the Status: Review needed Issue or PR is awaiting review label Mar 26, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 26, 2025 •
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello me-no-dev, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 5c70f49

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 26, 2025 •
edited
Loading

Test Results

 76 files   76 suites   12m 42s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit 5c70f49.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32P40⚠️ +2740.00⚠️ +0.050⚠️ +160.00⚠️ +0.06
ESP32S30⚠️ +1800.00⚠️ +0.03000.000.00
ESP32S20⚠️ +1920.00⚠️ +0.03000.000.00
ESP32C30⚠️ +2720.00⚠️ +0.050⚠️ +160.00⚠️ +0.09
ESP32C60⚠️ +2740.00⚠️ +0.05000.000.00
ESP32H20⚠️ +2740.00⚠️ +0.050⚠️ +160.00⚠️ +0.08
ESP320⚠️ +2000.00⚠️ +0.04000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/Ethernet/examples/ETH_TLK110⚠️ +264⚠️ +16----------⚠️ +1960
libraries/Ethernet/examples/ETH_W5500_Arduino_SPI⚠️ +274⚠️ +16⚠️ +1800⚠️ +1680⚠️ +272⚠️ +16⚠️ +2740⚠️ +274⚠️ +16⚠️ +2000
libraries/Ethernet/examples/ETH_W5500_IDF_SPI⚠️ +274⚠️ +16⚠️ +1800⚠️ +1800⚠️ +272⚠️ +16⚠️ +2740⚠️ +274⚠️ +16⚠️ +2000
libraries/Ethernet/examples/ETH_WIFI_BRIDGE⚠️ +270⚠️ +16⚠️ +1760⚠️ +1920⚠️ +2700⚠️ +2700--⚠️ +1960
libraries/Ethernet/examples/ETH_LAN8720------------⚠️ +1960

P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SuGlider
SuGlider approved these changes Mar 27, 2025
View reviewed changes
Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Mar 27, 2025
@me-no-dev me-no-dev merged commit df51bc3 into master Mar 27, 2025
46 checks passed
@me-no-dev me-no-dev deleted the bugfix/eth_options branch March 27, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasssvaz lucasssvaz lucasssvaz approved these changes

@SuGlider SuGlider SuGlider approved these changes

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees
No one assigned
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@me-no-dev @lucasssvaz @SuGlider @P-R-O-C-H-Y